eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (EAGLE-844) Potential NPE issue
Date Thu, 29 Dec 2016 04:35:58 GMT

     [ https://issues.apache.org/jira/browse/EAGLE-844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hao Chen updated EAGLE-844:
---------------------------
    Assignee:     (was: Hao Chen)

> Potential NPE issue
> -------------------
>
>                 Key: EAGLE-844
>                 URL: https://issues.apache.org/jira/browse/EAGLE-844
>             Project: Eagle
>          Issue Type: Bug
>            Reporter: Jaechang Nam
>            Priority: Minor
>
> The following file accessed on Dec 18 2016 (Github revision id: 8fe968cb7e340e2f21711b5a0f701e760cb91d59),
eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java,
seems to have a potential null pointer exception.
> {code}
> Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
>             if (entityServiceMap != null || entityServiceMap.values() != null) {
>                 for (EntityDefinition entityDefinition : entityServiceMap.values()) {
>                     createTable(entityDefinition);
>                 }
>             }
> {code}
> if entityServiceMap is null, entityServiceMap.values() could have NPE.
> I have no idea if entityServiceMap can be null. Having said that, at least it could be
a code smell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message