eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (EAGLE-687) When creating sites in UI and metadata storaged as jdbc, the field "Description" can't be null
Date Wed, 28 Dec 2016 08:26:58 GMT

    [ https://issues.apache.org/jira/browse/EAGLE-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782393#comment-15782393
] 

ASF GitHub Bot commented on EAGLE-687:
--------------------------------------

GitHub user jhsenjaliya opened a pull request:

    https://github.com/apache/eagle/pull/758

    [EAGLE-687] updating SiteEntityToRelation to accept null values

    Currently if you create site with any of the field set to NULL, it will throw 
    explored the way to use preparedStatements with explicitly specified parameters but that
would require quite a large refactoring on entire metadata module.
    so came up with the fix that is based on current assumptions in SiteEntityServiceJDBCImpl
which is forming the sql in particular way that suits in SiteEntityToRelation.accept method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jhsenjaliya/eagle EAGLE-687

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/eagle/pull/758.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #758
    
----
commit 3ffc3a9032aa207667b7a0ad9ccdb76bfcc0dfe1
Author: Jay <jhsonline@gmail.com>
Date:   2016-12-28T07:54:05Z

    updating SiteEntityToRelation to accept null values

----


> When creating sites in UI and metadata storaged as jdbc, the field "Description"  can't
be null
> -----------------------------------------------------------------------------------------------
>
>                 Key: EAGLE-687
>                 URL: https://issues.apache.org/jira/browse/EAGLE-687
>             Project: Eagle
>          Issue Type: Bug
>            Reporter: Lingang Deng
>            Priority: Minor
>             Fix For: v0.5.0
>
>
> When creating sites in UI and metadata storaged as jdbc, the field "Description"  can't
be null, or we will get error
> {code}
> ERROR [2016-10-26 15:54:24,554] org.apache.eagle.metadata.store.jdbc.JDBCMetadataMetadataStoreServiceImpl:
Error to insert batch: INSERT INTO sites (siteid, sitename, description, createdtime, modifiedtime,
uuid) VALUES (?, ?, ?, ?, ?, ?)
> ! java.sql.SQLException: No value specified for parameter 6
> {code}
> The  filed "Description" is checked in the background. So whether this field can be empty
or validated in the front end , it's elective.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message