eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zombieJ <...@git.apache.org>
Subject [GitHub] eagle pull request #753: EAGLE-845 JMX Dashboard
Date Fri, 30 Dec 2016 08:05:03 GMT
Github user zombieJ commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/753#discussion_r94208623
  
    --- Diff: eagle-hadoop-metric/src/main/webapp/app/apps/hadoop_metric/partials/overview.html
---
    @@ -33,17 +59,19 @@ <h3 class="box-title">
     		<span class="fa fa-line-chart"></span>
     		<h3 class="box-title">
     			Metrics
    +			<span>({{defaultHostname}})</span>
     		</h3>
     	</div>
     	<div class="box-body no-padding">
     		<div class="row border-split">
    -			<div class="col-sm-6 col-md-4 col-lg-3" ng-repeat="metric in metricList track by
$index">
    +			<div class="col-sm-6 col-md-6 col-lg-3" ng-repeat="metric in metricList track by
$index">
    --- End diff --
    
    May be `col-lg-4` instead? `col-lg-3` will much shorter when screen width from `col-md-6`
to `col-lg-3`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message