eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zombieJ <...@git.apache.org>
Subject [GitHub] eagle pull request #753: EAGLE-845 JMX Dashboard
Date Fri, 30 Dec 2016 08:05:03 GMT
Github user zombieJ commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/753#discussion_r94208526
  
    --- Diff: eagle-hadoop-metric/src/main/webapp/app/apps/hadoop_metric/partials/overview.html
---
    @@ -20,11 +20,37 @@
     	<div class="box-header with-border">
     		<span class="fa fa-television"></span>
     		<h3 class="box-title">
    -			Summary
    +			Service Summary Information
     		</h3>
     	</div>
     	<div class="box-body">
    -		TODO: Your summary
    +
    +		<table class="table table-striped">
    +			<tbody>
    +			<tr ng-if="regiontotal > 0">
    +				<th>RegionServer Status</th>
    +				<td class="text-break">
    +					<a ui-sref="regionList({siteId: site})" target="_blank">{{regiontotal}} RegionServers</a>
    +					<span class="label label-success">{{regionhealtynum}} Healthy</span>
    +					<span class="label label-danger">{{regiontotal - regionhealtynum}} UnHealthy</span>
    +				</td>
    +			</tr>
    +			<tr ng-if="hmasteractive !== undefined">
    --- End diff --
    
    Use `!!hmasteractive` or just `hmasteractive` instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message