eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From RalphSu <...@git.apache.org>
Subject [GitHub] incubator-eagle pull request #751: [EAGLE-844] Fix a potential NPE
Date Mon, 19 Dec 2016 02:12:02 GMT
Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/751#discussion_r92959638
  
    --- Diff: eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java
---
    @@ -65,7 +65,7 @@ public void init() {
             try {
                 admin = new HBaseAdmin(conf);
                 Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
    -            if (entityServiceMap != null || entityServiceMap.values() != null) {
    +            if (entityServiceMap != null && entityServiceMap.values() != null)
{
    --- End diff --
    
    do we still need to check "entityServiceMap.values() != null"?  it should not return null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message