eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haoch <...@git.apache.org>
Subject [GitHub] incubator-eagle pull request #750: [EAGLE-843] Refactor application shared s...
Date Fri, 16 Dec 2016 09:36:24 GMT
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/750#discussion_r92778513
  
    --- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/spi/ApplicationProvider.java
---
    @@ -72,7 +75,20 @@
          */
         void register(ModuleRegistry registry);
     
    -    default Optional<HealthCheck> getAppHealthCheck(Config config) {
    +    /**
    +     * @param config application config.
    +     * @return Application-specific managed health check.
    +     */
    +    default Optional<HealthCheck> getManagedHealthCheck(Config config) {
    +        return Optional.empty();
    +    }
    +
    +    /**
    +     *
    +     * @param envConfig server environment config.
    +     * @return Server-level shared services.
    +     */
    +    default Optional<List<Service>> getSharedServices(Config envConfig) {
    --- End diff --
    
    Change#1: add `Optional<List<Service>> getSharedServices(Config envConfig)
` in `ApplicationProvider`
    
    @qingwen220 @wujinhu 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message