eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r7raul1984 <...@git.apache.org>
Subject [GitHub] incubator-eagle issue #699: [MINOR] Add makeSSS and makeSRS in RouteSpec
Date Tue, 06 Dec 2016 00:45:54 GMT
Github user r7raul1984 commented on the issue:

    https://github.com/apache/incubator-eagle/pull/699
  
    This refactor has the following advantages:
    -   Reuseability
    Other object which have RouteSpec instance can reuse the makeSSS and makeSRS logic.
    
    -   Readability
    I think the logic is domain logic. So the logic that should be in a domain object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message