Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E04E9200BC7 for ; Fri, 25 Nov 2016 09:49:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DC108160B01; Fri, 25 Nov 2016 08:49:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CF4AD160AF6 for ; Fri, 25 Nov 2016 09:49:02 +0100 (CET) Received: (qmail 66324 invoked by uid 500); 25 Nov 2016 08:49:02 -0000 Mailing-List: contact issues-help@eagle.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@eagle.incubator.apache.org Delivered-To: mailing list issues@eagle.incubator.apache.org Received: (qmail 66311 invoked by uid 99); 25 Nov 2016 08:49:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Nov 2016 08:49:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A6506180BCC for ; Fri, 25 Nov 2016 08:49:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.218 X-Spam-Level: X-Spam-Status: No, score=-6.218 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id j_MpCievd9_M for ; Fri, 25 Nov 2016 08:48:59 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 8D50C5FC26 for ; Fri, 25 Nov 2016 08:48:59 +0000 (UTC) Received: (qmail 65791 invoked by uid 99); 25 Nov 2016 08:48:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Nov 2016 08:48:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D96062C03E2 for ; Fri, 25 Nov 2016 08:48:58 +0000 (UTC) Date: Fri, 25 Nov 2016 08:48:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@eagle.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (EAGLE-800) Use InterProcessMutex to sync operation in RunningJobManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 25 Nov 2016 08:49:04 -0000 [ https://issues.apache.org/jira/browse/EAGLE-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695287#comment-15695287 ] ASF GitHub Bot commented on EAGLE-800: -------------------------------------- Github user r7raul1984 commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/684#discussion_r89580934 --- Diff: eagle-jpm/eagle-jpm-util/src/main/java/org/apache/eagle/jpm/util/jobrecover/RunningJobManager.java --- @@ -49,12 +52,14 @@ private CuratorFramework newCurator(String zkQuorum, int zkSessionTimeoutMs, int ); } - public RunningJobManager(String zkQuorum, int zkSessionTimeoutMs, int zkRetryTimes, int zkRetryInterval, String zkRoot) { + public RunningJobManager(String zkQuorum, int zkSessionTimeoutMs, int zkRetryTimes, int zkRetryInterval, String zkRoot, String lockPath) { this.zkRoot = zkRoot; + curator = newCurator(zkQuorum, zkSessionTimeoutMs, zkRetryTimes, zkRetryInterval); + curator.start(); --- End diff -- OK.For now,I will catch it. > Use InterProcessMutex to sync operation in RunningJobManager > ------------------------------------------------------------ > > Key: EAGLE-800 > URL: https://issues.apache.org/jira/browse/EAGLE-800 > Project: Eagle > Issue Type: Improvement > Reporter: JiJun Tang > Assignee: JiJun Tang > Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)