Mailing-List: contact issues-help@eagle.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@eagle.incubator.apache.org
From: chitin <git@git.apache.org>
To: issues@eagle.incubator.apache.org
Reply-To: issues@eagle.incubator.apache.org
References: <git-pr-691-incubator-eagle@git.apache.org>
In-Reply-To: <git-pr-691-incubator-eagle@git.apache.org>
Subject: [GitHub] incubator-eagle pull request #691: EAGLE-796 MRJobEntityCreationHandler flus...
Content-Type: text/plain
Message-Id: <20161129063408.97C09DFF13@git1-us-west.apache.org>
Date: Tue, 29 Nov 2016 06:34:08 +0000 (UTC)
archived-at: Tue, 29 Nov 2016 06:34:13 -0000

Github user chitin commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/691#discussion_r89948452
  
    --- Diff: eagle-jpm/eagle-jpm-mr-running/src/main/java/org/apache/eagle/jpm/mr/running/parser/MRJobEntityCreationHandler.java ---
    @@ -79,10 +79,7 @@ public boolean flush() {
                 eagleServiceConfig.password);
             client.getJerseyClient().setReadTimeout(eagleServiceConfig.readTimeoutSeconds * 1000);
             try {
    -            LOG.info("start to flush mr job entities, size {}", entities.size());
    -            client.create(entities);
    -            LOG.info("finish flushing mr job entities, size {}", entities.size());
    -            entities.clear();
    +            return createEntities(client);
             } catch (Exception e) {
                 LOG.warn("exception found when flush entities, {}", e);
                 e.printStackTrace();
    --- End diff --
    
    Done.Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---