eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (EAGLE-804) make interface StreamContext more abstract
Date Mon, 28 Nov 2016 08:53:58 GMT

    [ https://issues.apache.org/jira/browse/EAGLE-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701342#comment-15701342
] 

ASF GitHub Bot commented on EAGLE-804:
--------------------------------------

Github user wujinhu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/690#discussion_r89737726
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/evaluator/impl/SiddhiPolicyHandler.java
---
    @@ -88,18 +88,18 @@ public void prepare(final Collector<AlertStreamEvent> collector,
PolicyHandlerCo
         }
     
         public void send(StreamEvent event) throws Exception {
    -        context.getPolicyCounter().scope(String.format("%s.%s", this.context.getPolicyDefinition().getName(),
"receive_count")).incr();
    +        context.getPolicyCounter().incr(String.format("%s.%s", this.context.getPolicyDefinition().getName(),
"receive_count"));
    --- End diff --
    
    I'm not quite sure about the performance of the incr() since there are a lot of method
call send(StreamEvent event). Do you evaluate it?


> make interface StreamContext more abstract
> ------------------------------------------
>
>                 Key: EAGLE-804
>                 URL: https://issues.apache.org/jira/browse/EAGLE-804
>             Project: Eagle
>          Issue Type: Improvement
>            Reporter: JiJun Tang
>            Assignee: JiJun Tang
>            Priority: Minor
>
> For now, interface  StreamContext is binded to Storm's count implement MultiCountMetric.We
should make it more abstract.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message