eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wujinhu <...@git.apache.org>
Subject [GitHub] incubator-eagle pull request #700: EAGLE-805 sync some operation in RunningJ...
Date Wed, 30 Nov 2016 09:51:09 GMT
Github user wujinhu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/700#discussion_r90199003
  
    --- Diff: eagle-jpm/eagle-jpm-util/src/main/java/org/apache/eagle/jpm/util/Utils.java
---
    @@ -116,6 +116,6 @@ public static long parseMemory(String memory) {
     
         public static String makeLockPath(String zkrootWithSiteId) {
             Preconditions.checkArgument(StringUtils.isNotBlank(zkrootWithSiteId), "zkrootWithSiteId
must not be blank");
    -        return zkrootWithSiteId.toLowerCase() + "/locks";
    +        return "/locks" + zkrootWithSiteId.toLowerCase();
    --- End diff --
    
    Pls refactor like:
    zkRoot/locks
    zkRoot/jobs/1
    zkRoot/jobs/2
    ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message