eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrettlish <...@git.apache.org>
Subject [GitHub] incubator-eagle issue #698: [EAGLE-814] fix alertId is null in AlertStreamEv...
Date Tue, 29 Nov 2016 10:22:01 GMT
Github user garrettlish commented on the issue:

    https://github.com/apache/incubator-eagle/pull/698
  
    + 1
    
    The issue is introduced by https://github.com/apache/incubator-eagle/commit/38ec7fc23d06c77b6e083ad2dfb9c61e729901e0#diff-2bb6be6fb3afdc59db75e1919ad89beaL97
which changed the alertId from AlertPublishEvent initialisation with random UUID to use AlertStreamEvent.alertId.
However, AlertStreamEvent.alertId is not always initialised. The fix looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message