eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wujinhu <...@git.apache.org>
Subject [GitHub] incubator-eagle pull request #690: [EAGLE-804] make interface StreamContext ...
Date Mon, 28 Nov 2016 08:53:44 GMT
Github user wujinhu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/690#discussion_r89737726
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/evaluator/impl/SiddhiPolicyHandler.java
---
    @@ -88,18 +88,18 @@ public void prepare(final Collector<AlertStreamEvent> collector,
PolicyHandlerCo
         }
     
         public void send(StreamEvent event) throws Exception {
    -        context.getPolicyCounter().scope(String.format("%s.%s", this.context.getPolicyDefinition().getName(),
"receive_count")).incr();
    +        context.getPolicyCounter().incr(String.format("%s.%s", this.context.getPolicyDefinition().getName(),
"receive_count"));
    --- End diff --
    
    I'm not quite sure about the performance of the incr() since there are a lot of method
call send(StreamEvent event). Do you evaluate it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message