eagle-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haoch <...@git.apache.org>
Subject [GitHub] incubator-eagle pull request #671: [EAGLE-787] add healthy check for hadoop-...
Date Mon, 21 Nov 2016 12:57:20 GMT
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/671#discussion_r88888445
  
    --- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/spi/ApplicationProvider.java
---
    @@ -72,7 +73,7 @@
          */
         void register(ModuleRegistry registry);
     
    -    default HealthCheck getAppHealthCheck(Config config) {
    +    default HealthCheck getAppHealthCheck(Config config, ApplicationEntityService applicationEntityService)
{
    --- End diff --
    
    The interface is not extensible enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message