eagle-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ji...@apache.org
Subject eagle git commit: [MINOR] Fix jslint of $notification
Date Tue, 28 Feb 2017 06:49:34 GMT
Repository: eagle
Updated Branches:
  refs/heads/master 1c90aa46d -> 07990e3e7


[MINOR] Fix jslint of $notification

jslint check for the notification with warning

Author: zombieJ <smith3816@gmail.com>

Closes #847 from zombieJ/minor.


Project: http://git-wip-us.apache.org/repos/asf/eagle/repo
Commit: http://git-wip-us.apache.org/repos/asf/eagle/commit/07990e3e
Tree: http://git-wip-us.apache.org/repos/asf/eagle/tree/07990e3e
Diff: http://git-wip-us.apache.org/repos/asf/eagle/diff/07990e3e

Branch: refs/heads/master
Commit: 07990e3e7cbda78babada5dfe2b7295e837115a0
Parents: 1c90aa4
Author: zombieJ <smith3816@gmail.com>
Authored: Tue Feb 28 14:49:14 2017 +0800
Committer: zombieJ <smith3816@gmail.com>
Committed: Tue Feb 28 14:49:14 2017 +0800

----------------------------------------------------------------------
 .../src/main/webapp/app/dev/public/js/services/notificationSrv.js  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/eagle/blob/07990e3e/eagle-server/src/main/webapp/app/dev/public/js/services/notificationSrv.js
----------------------------------------------------------------------
diff --git a/eagle-server/src/main/webapp/app/dev/public/js/services/notificationSrv.js b/eagle-server/src/main/webapp/app/dev/public/js/services/notificationSrv.js
index 76f9c45..391edcf 100644
--- a/eagle-server/src/main/webapp/app/dev/public/js/services/notificationSrv.js
+++ b/eagle-server/src/main/webapp/app/dev/public/js/services/notificationSrv.js
@@ -103,7 +103,7 @@
 			});
 		}
 
-		if (!'Notification' in window || !'localStorage' in window) {
+		if (!('Notification' in window) || !('localStorage' in window)) {
 			// Notification not support
 			console.warn('Browser do not support Notification api. Ignore...');
 		} else {


Mime
View raw message