Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 71249200BB7 for ; Wed, 9 Nov 2016 15:03:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6FB48160AF7; Wed, 9 Nov 2016 14:03:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B74E9160AEE for ; Wed, 9 Nov 2016 15:03:51 +0100 (CET) Received: (qmail 39829 invoked by uid 500); 9 Nov 2016 14:03:50 -0000 Mailing-List: contact commits-help@eagle.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@eagle.incubator.apache.org Delivered-To: mailing list commits@eagle.incubator.apache.org Received: (qmail 39820 invoked by uid 99); 9 Nov 2016 14:03:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2016 14:03:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F1E041A02FD for ; Wed, 9 Nov 2016 14:03:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ximI0X_puyvr for ; Wed, 9 Nov 2016 14:03:49 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 805875FC86 for ; Wed, 9 Nov 2016 14:03:48 +0000 (UTC) Received: (qmail 33869 invoked by uid 99); 9 Nov 2016 14:01:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2016 14:01:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 302EFE09D3; Wed, 9 Nov 2016 14:01:18 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: hao@apache.org To: commits@eagle.incubator.apache.org Date: Wed, 09 Nov 2016 14:01:18 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] incubator-eagle git commit: [EAGLE-738] Fix eagle-metadata checkstyle warnings archived-at: Wed, 09 Nov 2016 14:03:52 -0000 Repository: incubator-eagle Updated Branches: refs/heads/master a88e1cef8 -> 32582d230 http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/32582d23/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java ---------------------------------------------------------------------- diff --git a/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java b/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java index 3315fc3..adfe8f2 100644 --- a/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java +++ b/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java @@ -19,13 +19,9 @@ package org.apache.eagle.metadata.store.jdbc; import com.google.inject.Guice; import com.google.inject.Inject; import com.google.inject.Injector; -import com.typesafe.config.ConfigFactory; import org.apache.commons.dbcp.BasicDataSource; import org.apache.eagle.app.module.ApplicationGuiceModule; -import org.apache.eagle.app.service.ApplicationProviderService; -import org.apache.eagle.app.service.impl.ApplicationProviderServiceImpl; import org.apache.eagle.common.module.CommonGuiceModule; -import org.apache.eagle.metadata.store.jdbc.JDBCMetadataStore; import org.junit.After; import org.junit.Before; @@ -39,19 +35,19 @@ public class JDBCMetadataTestBase { private DataSource dataSource; @Before - public void setUp(){ - injector = Guice.createInjector(new JDBCMetadataStore(),new ApplicationGuiceModule(),new CommonGuiceModule()); + public void setUp() { + injector = Guice.createInjector(new JDBCMetadataStore(), new ApplicationGuiceModule(), new CommonGuiceModule()); injector.injectMembers(this); } @After public void after() throws SQLException { - if(dataSource!=null){ + if (dataSource != null) { ((BasicDataSource) dataSource).close(); } } - public Injector injector(){ + public Injector injector() { return injector; } } http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/32582d23/eagle-core/eagle-metadata/pom.xml ---------------------------------------------------------------------- diff --git a/eagle-core/eagle-metadata/pom.xml b/eagle-core/eagle-metadata/pom.xml index 676327e..57dde36 100644 --- a/eagle-core/eagle-metadata/pom.xml +++ b/eagle-core/eagle-metadata/pom.xml @@ -33,4 +33,16 @@ eagle-metadata-mongo eagle-metadata-base + + + + org.apache.maven.plugins + maven-checkstyle-plugin + + true + true + + + + \ No newline at end of file