eagle-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From h..@apache.org
Subject [1/2] incubator-eagle git commit: [EAGLE-738] Fix eagle-metadata checkstyle warnings
Date Wed, 09 Nov 2016 14:01:18 GMT
Repository: incubator-eagle
Updated Branches:
  refs/heads/master a88e1cef8 -> 32582d230


http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/32582d23/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java
----------------------------------------------------------------------
diff --git a/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java
b/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java
index 3315fc3..adfe8f2 100644
--- a/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java
+++ b/eagle-core/eagle-metadata/eagle-metadata-jdbc/src/test/java/org/apache/eagle/metadata/store/jdbc/JDBCMetadataTestBase.java
@@ -19,13 +19,9 @@ package org.apache.eagle.metadata.store.jdbc;
 import com.google.inject.Guice;
 import com.google.inject.Inject;
 import com.google.inject.Injector;
-import com.typesafe.config.ConfigFactory;
 import org.apache.commons.dbcp.BasicDataSource;
 import org.apache.eagle.app.module.ApplicationGuiceModule;
-import org.apache.eagle.app.service.ApplicationProviderService;
-import org.apache.eagle.app.service.impl.ApplicationProviderServiceImpl;
 import org.apache.eagle.common.module.CommonGuiceModule;
-import org.apache.eagle.metadata.store.jdbc.JDBCMetadataStore;
 import org.junit.After;
 import org.junit.Before;
 
@@ -39,19 +35,19 @@ public class JDBCMetadataTestBase {
     private DataSource dataSource;
 
     @Before
-    public void setUp(){
-        injector = Guice.createInjector(new JDBCMetadataStore(),new ApplicationGuiceModule(),new
CommonGuiceModule());
+    public void setUp() {
+        injector = Guice.createInjector(new JDBCMetadataStore(), new ApplicationGuiceModule(),
new CommonGuiceModule());
         injector.injectMembers(this);
     }
 
     @After
     public void after() throws SQLException {
-        if(dataSource!=null){
+        if (dataSource != null) {
             ((BasicDataSource) dataSource).close();
         }
     }
 
-    public Injector injector(){
+    public Injector injector() {
         return injector;
     }
 }

http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/32582d23/eagle-core/eagle-metadata/pom.xml
----------------------------------------------------------------------
diff --git a/eagle-core/eagle-metadata/pom.xml b/eagle-core/eagle-metadata/pom.xml
index 676327e..57dde36 100644
--- a/eagle-core/eagle-metadata/pom.xml
+++ b/eagle-core/eagle-metadata/pom.xml
@@ -33,4 +33,16 @@
         <module>eagle-metadata-mongo</module>
         <module>eagle-metadata-base</module>
     </modules>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <failOnViolation>true</failOnViolation>
+                    <failsOnError>true</failsOnError>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
 </project>
\ No newline at end of file


Mime
View raw message