From notifications-return-6216-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Sun Sep 2 13:03:16 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 77A41180651 for ; Sun, 2 Sep 2018 13:03:15 +0200 (CEST) Received: (qmail 66105 invoked by uid 500); 2 Sep 2018 11:03:14 -0000 Mailing-List: contact notifications-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list notifications@dubbo.apache.org Received: (qmail 66096 invoked by uid 99); 2 Sep 2018 11:03:14 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Sep 2018 11:03:14 +0000 From: GitBox To: notifications@dubbo.apache.org Subject: [GitHub] satansk commented on a change in pull request #2426: [Dubbo-2424] Fix switch-case fall through in ChannelEventRunnable Message-ID: <153588619412.20381.5873233943496937797.gitbox@gitbox.apache.org> Date: Sun, 02 Sep 2018 11:03:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit satansk commented on a change in pull request #2426: [Dubbo-2424] Fix switch-case fall through in ChannelEventRunnable URL: https://github.com/apache/incubator-dubbo/pull/2426#discussion_r214536538 ########## File path: dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/dispatcher/ChannelEventRunnable.java ########## @@ -82,6 +82,7 @@ public void run() { logger.warn("ChannelEventRunnable handle " + state + " operation error, channel is " + channel + ", message is " + message, e); } + break; Review comment: Good catch! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org For additional commands, e-mail: notifications-help@dubbo.apache.org