dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] satansk commented on a change in pull request #2426: [Dubbo-2424] Fix switch-case fall through in ChannelEventRunnable
Date Sun, 02 Sep 2018 11:03:14 GMT
satansk commented on a change in pull request #2426: [Dubbo-2424] Fix switch-case fall through
in ChannelEventRunnable
URL: https://github.com/apache/incubator-dubbo/pull/2426#discussion_r214536538
 
 

 ##########
 File path: dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/dispatcher/ChannelEventRunnable.java
 ##########
 @@ -82,6 +82,7 @@ public void run() {
                     logger.warn("ChannelEventRunnable handle " + state + " operation error,
channel is " + channel
                             + ", message is " + message, e);
                 }
+                break;
 
 Review comment:
   Good catch!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message