dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] codecov-io commented on issue #2428: Minor code refactoring
Date Sun, 02 Sep 2018 09:57:33 GMT
codecov-io commented on issue #2428: Minor code refactoring
URL: https://github.com/apache/incubator-dubbo/pull/2428#issuecomment-417918294
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2428?src=pr&el=h1) Report
   > Merging [#2428](https://codecov.io/gh/apache/incubator-dubbo/pull/2428?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/2ae2f582a155a8ab76ea3f599ad31548d4001fbb?src=pr&el=desc)
will **decrease** coverage by `0.08%`.
   > The diff coverage is `78.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2428?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2428      +/-   ##
   ============================================
   - Coverage     55.14%   55.06%   -0.09%     
   + Complexity     5274     5268       -6     
   ============================================
     Files           573      573              
     Lines         25459    25460       +1     
     Branches       4537     4533       -4     
   ============================================
   - Hits          14039    14019      -20     
   - Misses         9327     9348      +21     
     Partials       2093     2093
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2428?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rpc/cluster/configurator/AbstractConfigurator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvY29uZmlndXJhdG9yL0Fic3RyYWN0Q29uZmlndXJhdG9yLmphdmE=)
| `43.47% <0%> (+0.92%)` | `8 <1> (ø)` | :arrow_down: |
   | [...bo/rpc/cluster/support/FailoverClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsb3ZlckNsdXN0ZXJJbnZva2VyLmphdmE=)
| `88.88% <100%> (+4.44%)` | `7 <0> (ø)` | :arrow_down: |
   | [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=)
| `86.48% <100%> (-0.36%)` | `8 <0> (ø)` | |
   | [...bo/rpc/cluster/support/AbstractClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9BYnN0cmFjdENsdXN0ZXJJbnZva2VyLmphdmE=)
| `70.87% <100%> (-0.29%)` | `42 <1> (ø)` | |
   | [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==)
| `51.07% <100%> (-0.35%)` | `42 <0> (-1)` | |
   | [...bbo/rpc/cluster/support/ForkingClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Gb3JraW5nQ2x1c3Rlckludm9rZXIuamF2YQ==)
| `85.71% <66.66%> (ø)` | `7 <0> (ø)` | :arrow_down: |
   | [...bo/rpc/cluster/support/FailfastClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsZmFzdENsdXN0ZXJJbnZva2VyLmphdmE=)
| `80% <85.71%> (+13.33%)` | `4 <0> (ø)` | :arrow_down: |
   | [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=)
| `45.45% <0%> (-11.37%)` | `7% <0%> (-1%)` | |
   | [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh)
| `72.88% <0%> (-10.17%)` | `12% <0%> (-1%)` | |
   | [...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0Z1dHVyZUFkYXB0ZXIuamF2YQ==)
| `58.06% <0%> (-6.46%)` | `3% <0%> (ø)` | |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2428/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2428?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2428?src=pr&el=footer).
Last update [2ae2f58...9466504](https://codecov.io/gh/apache/incubator-dubbo/pull/2428?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message