dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] codecov-io commented on issue #2414: [Dubbo-2413] Fix StreamUtils resource leak
Date Sat, 01 Sep 2018 07:34:37 GMT
codecov-io commented on issue #2414: [Dubbo-2413] Fix StreamUtils resource leak
URL: https://github.com/apache/incubator-dubbo/pull/2414#issuecomment-417840052
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2414?src=pr&el=h1) Report
   > Merging [#2414](https://codecov.io/gh/apache/incubator-dubbo/pull/2414?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ff373a7db7645ea1b55bf84150d0326d1e999b78?src=pr&el=desc)
will **increase** coverage by `0.25%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2414?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2414      +/-   ##
   ============================================
   + Coverage     54.84%   55.09%   +0.25%     
   - Complexity     5238     5284      +46     
   ============================================
     Files           573      573              
     Lines         25455    25495      +40     
     Branches       4537     4540       +3     
   ============================================
   + Hits          13960    14046      +86     
   + Misses         9402     9348      -54     
   - Partials       2093     2101       +8
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2414?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/java/org/apache/dubbo/common/io/StreamUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vaW8vU3RyZWFtVXRpbHMuamF2YQ==)
| `84.44% <100%> (+0.53%)` | `5 <0> (ø)` | :arrow_down: |
   | [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=)
| `45.45% <0%> (-11.37%)` | `7% <0%> (-1%)` | |
   | [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==)
| `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
   | [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh)
| `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
   | [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh)
| `85.45% <0%> (-2.22%)` | `57% <0%> (+19%)` | |
   | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==)
| `67.41% <0%> (-1.88%)` | `62% <0%> (-1%)` | |
   | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNvZGVjQWRhcHRlci5qYXZh)
| `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
   | [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==)
| `44.96% <0%> (+0.67%)` | `25% <0%> (+1%)` | :arrow_up: |
   | [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==)
| `59.16% <0%> (+0.83%)` | `31% <0%> (+1%)` | :arrow_up: |
   | [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=)
| `78.67% <0%> (+1.47%)` | `29% <0%> (ø)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2414/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2414?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2414?src=pr&el=footer).
Last update [ff373a7...266c550](https://codecov.io/gh/apache/incubator-dubbo/pull/2414?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message