From notifications-return-381-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Wed May 2 08:00:13 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6B8B518065D for ; Wed, 2 May 2018 08:00:13 +0200 (CEST) Received: (qmail 91401 invoked by uid 500); 2 May 2018 06:00:12 -0000 Mailing-List: contact notifications-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list notifications@dubbo.apache.org Received: (qmail 91392 invoked by uid 99); 2 May 2018 06:00:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 06:00:12 +0000 From: GitBox To: notifications@dubbo.apache.org Subject: [GitHub] beiwei30 opened a new issue #1725: System property dubbo.registry.address cannot have multiple values Message-ID: <152524081188.13099.5128050106632501612.gitbox@gitbox.apache.org> Date: Wed, 02 May 2018 06:00:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit beiwei30 opened a new issue #1725: System property dubbo.registry.address cannot have multiple values URL: https://github.com/apache/incubator-dubbo/issues/1725 In com.alibaba.dubbo.config.AbstractInterfaceConfig#checkRegistry, there's code snippet to handle backward compatibility when there are multiple registry addresses in `dubbo.registry.address`, say: "addr1|addr2": ```java // for backward compatibility if (registries == null || registries.isEmpty()) { String address = ConfigUtils.getProperty("dubbo.registry.address"); if (address != null && address.length() > 0) { registries = new ArrayList(); String[] as = address.split("\\s*[|]+\\s*"); for (String a : as) { RegistryConfig registryConfig = new RegistryConfig(); registryConfig.setAddress(a); registries.add(registryConfig); } } } ``` but later, appendProperties is called so that the value from `dubbo.registry.address` will override the address value from each RegistryConfig, for registryConfig1, its address becomes from 'addr1' to 'addr1|addr2': ```java for (RegistryConfig registryConfig : registries) { appendProperties(registryConfig); } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org For additional commands, e-mail: notifications-help@dubbo.apache.org