dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] htynkn commented on a change in pull request #1721: [Dubbo-1681] add test for dubbo common module
Date Thu, 03 May 2018 06:08:01 GMT
htynkn commented on a change in pull request #1721: [Dubbo-1681] add test for dubbo common
URL: https://github.com/apache/incubator-dubbo/pull/1721#discussion_r185702820

 File path: dubbo-common/src/test/java/com/alibaba/dubbo/common/io/UnsafeByteArrayOutputStreamTest.java
 @@ -0,0 +1,76 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.alibaba.dubbo.common.io;
+import org.junit.Test;
+import org.mockito.Mockito;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.nio.ByteBuffer;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+import static org.mockito.ArgumentMatchers.*;
 Review comment:
   @beiwei30 sorry, I thought checkstyle rule should check * import... but looks like it's
only enable for source, not test folder.
   I already fix * imports issue. Please refer to last commit

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

View raw message