dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] diecui1202 opened a new pull request #1726: optimize unit test for serialization hession2/jdk/kryo
Date Wed, 02 May 2018 09:07:20 GMT
diecui1202 opened a new pull request #1726: optimize unit test for serialization hession2/jdk/kryo
URL: https://github.com/apache/incubator-dubbo/pull/1726
   ## What is the purpose of the change
   optimize unit test for serialization hession2/jdk/kryo
   ## Brief changelog
   	modified:   dubbo-serialization-hessian2/src/test/java/com/alibaba/dubbo/common/serialize/serialization/AbstractSerializationTest.java
   	modified:   dubbo-serialization-jdk/src/test/java/com/alibaba/dubbo/common/serialize/serialization/AbstractSerializationTest.java
   	new file:   dubbo-serialization-jdk/src/test/java/com/alibaba/dubbo/common/serialize/serialization/NativeJavaSerializationTest.java
   	modified:   dubbo-serialization-kryo/src/test/java/com/alibaba/dubbo/common/serialize/serialization/AbstractSerializationTest.java
   ## Verifying this change
   All unit test cases are pass.
   Follow this checklist to help us incorporate your contribution quickly and easily:
   - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues)
filed for the change (usually before you start working on it). Trivial changes like typos
do not require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist #XXX`. Each commit in the pull request should have a meaningful subject line and
   - [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test`
to make sure unit-test and integration-test pass.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

View raw message