From dev-return-1477-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Mon Apr 16 03:36:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9E5F8180648 for ; Mon, 16 Apr 2018 03:36:50 +0200 (CEST) Received: (qmail 23633 invoked by uid 500); 16 Apr 2018 01:36:49 -0000 Mailing-List: contact dev-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list dev@dubbo.apache.org Received: (qmail 23622 invoked by uid 99); 16 Apr 2018 01:36:49 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2018 01:36:49 +0000 Received: from mail-oi0-f44.google.com (mail-oi0-f44.google.com [209.85.218.44]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id BB0892B5A for ; Mon, 16 Apr 2018 01:36:48 +0000 (UTC) Received: by mail-oi0-f44.google.com with SMTP id 188-v6so13090944oih.8 for ; Sun, 15 Apr 2018 18:36:48 -0700 (PDT) X-Gm-Message-State: ALQs6tDkrfmUgV+XTYPJZmcAqNa07l7uTw/+i82NbIjP3WkMZVRpibwd /ocIaArBVYsTxlZxRyI6GXKdBMrLj2AIZYV4iA== X-Google-Smtp-Source: AIpwx49B/FVrIgSY5eC4gkcsf/XttAI0YklmQCc5UMcYP0gVEsjtv/dDQ4PSgXIKGzjB9s0PRygIqIBEVosD9WtMpOg= X-Received: by 2002:aca:c18b:: with SMTP id r133-v6mr13951694oif.286.1523842607673; Sun, 15 Apr 2018 18:36:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.138.7.68 with HTTP; Sun, 15 Apr 2018 18:36:17 -0700 (PDT) In-Reply-To: References: <1226017d.3671.162ad5b6a14.Coremail.htynkn@163.com> From: Huxing Zhang Date: Mon, 16 Apr 2018 09:36:17 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Suggestion] PR failing if test coverage went down To: dev@dubbo.apache.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Thu, Apr 12, 2018 at 11:07 AM, htynkn@gmail.com wrote= : > yeah. I understand your concern. > > This is a common requirement for coverage calc service. Codecov support t= his feature. > In codecov.yml, we can config threshold value which allow the coverage to= drop by X%, and posting a success status. That is awesome! What is your suggestion of X? > > Regards, > Yunkun Huang > > On 2018/04/10 06:36:03, Huxing Zhang wrote: >> Hi, >> >> Thanks for the suggestion. >> >> I generally agree with the idea that we should prevent a pull request >> to be merged if the code coverage gets lower. >> >> But my concern is the code coverage might have a minor drop even when >> just fixing typo[1], which makes confused. >> >> Unless we can figure it out, or I think it will be better if we can >> set a threshold. >> >> For example, if the code coverage drops >=3D0.1%, prevent the PR to be m= erged. >> >> [1] https://github.com/apache/incubator-dubbo/pull/1562 >> >> On Tue, Apr 10, 2018 at 10:21 AM, htynkn wrote: >> > hey team, >> > >> > >> > In pull request template(https://github.com/apache/incubator-dubbo/blo= b/master/PULL_REQUEST_TEMPLATE.md), this is one item to ask all pr to >> > >> > >> > "Write necessary unit-test to verify your logic correction" >> > >> > >> > Codecov has feature to fail PR if test coverage went down. Which means= for any pull request, if it add some code without any unit test, the PR wi= ll fail >> > This can help to increase test coverage. >> > >> > >> > Any thoughts? >> > >> > >> > Relate links: >> > 1.https://docs.codecov.io/docs/commit-status >> > 2.https://github.com/codecov/support/issues/351 >> > >> >> -- >> Best Regards=EF=BC=81 >> Huxing >> --=20 Best Regards=EF=BC=81 Huxing