From dev-return-1118-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Mon Apr 9 08:49:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8B9D61807A3 for ; Mon, 9 Apr 2018 08:49:49 +0200 (CEST) Received: (qmail 53806 invoked by uid 500); 9 Apr 2018 06:49:48 -0000 Mailing-List: contact dev-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list dev@dubbo.apache.org Received: (qmail 53131 invoked by uid 99); 9 Apr 2018 06:49:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Apr 2018 06:49:47 +0000 From: GitBox To: dev@dubbo.apache.org Subject: [GitHub] beiwei30 commented on a change in pull request #1568: Extension: Enhanced Thread Pool Message-ID: <152325658727.461.7579656294516228694.gitbox@gitbox.apache.org> Date: Mon, 09 Apr 2018 06:49:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit beiwei30 commented on a change in pull request #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#discussion_r179999993 ########## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/enhanced/EnhancedThreadPoolExecutor.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.dubbo.common.threadpool.support.enhanced; + +import java.util.concurrent.RejectedExecutionHandler; +import java.util.concurrent.ThreadFactory; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.RejectedExecutionException; +import java.util.concurrent.atomic.AtomicInteger; + +/** + * Enhanced thread pool + */ +public class EnhancedThreadPoolExecutor extends ThreadPoolExecutor { + + //task count + private final AtomicInteger submittedTaskCount = new AtomicInteger(0); + + public EnhancedThreadPoolExecutor(int corePoolSize, int maximumPoolSize, long keepAliveTime, TimeUnit unit, EnhancedTaskQueue workQueue, ThreadFactory threadFactory, RejectedExecutionHandler handler) { + super(corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, threadFactory, handler); + } + + /** + * @return current tasks which are executed + */ + public int getSubmittedTaskCount() { + return submittedTaskCount.get(); + } + + @Override + protected void afterExecute(Runnable r, Throwable t) { + submittedTaskCount.decrementAndGet(); + } + + @Override + public void execute(Runnable command) { + //do not increment in method beforeExecute! + submittedTaskCount.incrementAndGet(); + try { + super.execute(command); + } catch (RejectedExecutionException rx) { + //retry to offer the task into queue . Review comment: add space after `//` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services