From dev-return-1065-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Sun Apr 8 11:37:41 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 03D54180638 for ; Sun, 8 Apr 2018 11:37:40 +0200 (CEST) Received: (qmail 18415 invoked by uid 500); 8 Apr 2018 09:37:40 -0000 Mailing-List: contact dev-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list dev@dubbo.apache.org Received: (qmail 18398 invoked by uid 99); 8 Apr 2018 09:37:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Apr 2018 09:37:40 +0000 From: GitBox To: dev@dubbo.apache.org Subject: [GitHub] YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters Message-ID: <152318025947.10807.8935654639670559264.gitbox@gitbox.apache.org> Date: Sun, 08 Apr 2018 09:37:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit YoungHu commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179941847 ########## File path: dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/MonitorConfig.java ########## @@ -123,4 +125,12 @@ public void setDefault(Boolean isDefault) { this.isDefault = isDefault; } + public void setInterval(String interval){ + this.interval = interval; + } + + public String getInterval(){ Review comment: no one call `getInterval()` direct, this is used for fastjson serialize, so it can be passed to `URL` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services