From dev-return-1018-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org  Sun Apr  8 08:14:32 2018
Return-Path: <dev-return-1018-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id C89D6180638
	for <archive-asf-public@cust-asf.ponee.io>; Sun,  8 Apr 2018 08:14:31 +0200 (CEST)
Received: (qmail 91753 invoked by uid 500); 8 Apr 2018 06:14:30 -0000
Mailing-List: contact dev-help@dubbo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@dubbo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@dubbo.apache.org>
List-Post: <mailto:dev@dubbo.apache.org>
List-Id: <dev.dubbo.apache.org>
Reply-To: dev@dubbo.apache.org
Delivered-To: mailing list dev@dubbo.apache.org
Received: (qmail 91742 invoked by uid 99); 8 Apr 2018 06:14:30 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Apr 2018 06:14:30 +0000
From: GitBox <git@apache.org>
To: dev@dubbo.apache.org
Subject: [GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]
Message-ID: <152316806992.12171.13818177998641603568.gitbox@gitbox.apache.org>
Date: Sun, 08 Apr 2018 06:14:29 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936669
 
 

 ##########
 File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
 ##########
 @@ -98,13 +110,88 @@ public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) t
         Set<String> resolvedPackagesToScan = resolvePackagesToScan(packagesToScan);
 
         if (!CollectionUtils.isEmpty(resolvedPackagesToScan)) {
+
+            // register @Service
             registerServiceBeans(resolvedPackagesToScan, registry);
+
+            // register @Component
+            registerComponentBeans(resolvedPackagesToScan, registry);
         } else {
             if (logger.isWarnEnabled()) {
                 logger.warn("packagesToScan is empty , ServiceBean registry will be ignored!");
             }
         }
 
+        /**
+         * The solution to consumers early references to unexposed services.
+         */
+        deferConfiguationBeans();
+
+    }
+
+    /**
+     * Registers Beans whose classes was annotated {@link Component}
+     *
+     * @param packagesToScan The base packages to scan
+     * @param registry       {@link BeanDefinitionRegistry}
+     */
+    private void registerComponentBeans(Set<String> packagesToScan, BeanDefinitionRegistry registry) {
+
+        DubboClassPathBeanDefinitionScanner scanner =
+                new DubboClassPathBeanDefinitionScanner(registry, environment, resourceLoader);
+
+        BeanNameGenerator beanNameGenerator = resolveBeanNameGenerator(registry);
+
+        scanner.setBeanNameGenerator(beanNameGenerator);
+
+        scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, false));
 
 Review comment:
   Process discovery and @Component under the same service package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services