From dev-return-904-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Thu Apr 5 18:05:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 52BDA18063B for ; Thu, 5 Apr 2018 18:05:47 +0200 (CEST) Received: (qmail 84392 invoked by uid 500); 5 Apr 2018 16:05:46 -0000 Mailing-List: contact dev-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list dev@dubbo.apache.org Received: (qmail 84378 invoked by uid 99); 5 Apr 2018 16:05:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2018 16:05:46 +0000 From: GitBox To: dev@dubbo.apache.org Subject: [GitHub] zonghaishang commented on a change in pull request #1511: Add feature：require Reference service dynamically Message-ID: <152294434544.414.14767724212726643221.gitbox@gitbox.apache.org> Date: Thu, 05 Apr 2018 16:05:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit zonghaishang commented on a change in pull request #1511: Add feature：require Reference service dynamically URL: https://github.com/apache/incubator-dubbo/pull/1511#discussion_r179516001 ########## File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/AnnotationBean.java ########## @@ -288,6 +296,73 @@ private Object refer(Reference reference, Class referenceClass) { //method.ge return referenceConfig.get(); } + /** + * refer 方法的公开版，将注解参数Reference换为 ReferenceConf 类 + * @param reference + * @param referenceClass + * @return + */ + public Object referNew(RefConf reference, Class referenceClass) { //method.getParameterTypes()[0] + String interfaceName; + + if (! "".equals( reference.interfaceName)) { Review comment: @zhouzhipeng Existing refer methods is private, you can rename refer to refer0, I think use refer better than referNew. Of course, it's all depends on you, thank you very much for your contribution. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services