From dev-return-864-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Wed Apr 4 10:48:01 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F01218064F for ; Wed, 4 Apr 2018 10:48:00 +0200 (CEST) Received: (qmail 76133 invoked by uid 500); 4 Apr 2018 08:47:59 -0000 Mailing-List: contact dev-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list dev@dubbo.apache.org Received: (qmail 76122 invoked by uid 99); 4 Apr 2018 08:47:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 08:47:59 +0000 From: GitBox To: dev@dubbo.apache.org Subject: [GitHub] codecov-io commented on issue #1553: add missing @Override to classes Message-ID: <152283167857.5681.6878255133326556499.gitbox@gitbox.apache.org> Date: Wed, 04 Apr 2018 08:47:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io commented on issue #1553: add missing @Override to classes URL: https://github.com/apache/incubator-dubbo/pull/1553#issuecomment-378527493 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1553?src=pr&el=h1) Report > Merging [#1553](https://codecov.io/gh/apache/incubator-dubbo/pull/1553?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ab2af6956cded331b6f04164ab7976f2cb7812ea?src=pr&el=desc) will **increase** coverage by `0.9%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/graphs/tree.svg?token=VnEIkiFQT0&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1553?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1553 +/- ## ========================================= + Coverage 30.69% 31.59% +0.9% ========================================= Files 682 682 Lines 32174 33048 +874 Branches 6294 6597 +303 ========================================= + Hits 9877 10443 +566 - Misses 20591 20748 +157 - Partials 1706 1857 +151 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1553?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../com/alibaba/dubbo/rpc/filter/ExceptionFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0V4Y2VwdGlvbkZpbHRlci5qYXZh) | `21.42% <ø> (+1.98%)` | :arrow_up: | | [...baba/dubbo/remoting/transport/ChannelDelegate.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L0NoYW5uZWxEZWxlZ2F0ZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [.../dispatcher/execution/ExecutionChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L2Rpc3BhdGNoZXIvZXhlY3V0aW9uL0V4ZWN1dGlvbkNoYW5uZWxIYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...baba/dubbo/rpc/protocol/AbstractProxyProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvQWJzdHJhY3RQcm94eVByb3RvY29sLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...ibaba/dubbo/rpc/cluster/merger/IntArrayMerger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL21lcmdlci9JbnRBcnJheU1lcmdlci5qYXZh) | `100% <ø> (ø)` | :arrow_up: | | [...aba/dubbo/rpc/cluster/support/FailoverCluster.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3N1cHBvcnQvRmFpbG92ZXJDbHVzdGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [.../rpc/protocol/dubbo/telnet/CountTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvQ291bnRUZWxuZXRIYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...alibaba/dubbo/common/logger/slf4j/Slf4jLogger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2xvZ2dlci9zbGY0ai9TbGY0akxvZ2dlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...dubbo/remoting/http/servlet/DispatcherServlet.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctaHR0cC9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL2h0dHAvc2VydmxldC9EaXNwYXRjaGVyU2VydmxldC5qYXZh) | `64.28% <ø> (ø)` | :arrow_up: | | [...alibaba/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib0ludm9rZXIuamF2YQ==) | `71.42% <ø> (-1.3%)` | :arrow_down: | | ... and [585 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1553/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1553?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1553?src=pr&el=footer). Last update [ab2af69...6975eec](https://codecov.io/gh/apache/incubator-dubbo/pull/1553?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services