From dev-return-791-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Tue Apr 3 09:15:29 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D1AA318064D for ; Tue, 3 Apr 2018 09:15:28 +0200 (CEST) Received: (qmail 50126 invoked by uid 500); 3 Apr 2018 07:15:27 -0000 Mailing-List: contact dev-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list dev@dubbo.apache.org Received: (qmail 50114 invoked by uid 99); 3 Apr 2018 07:15:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2018 07:15:27 +0000 From: GitBox To: dev@dubbo.apache.org Subject: [GitHub] codecov-io commented on issue #1509: add unit test for remoting module Message-ID: <152273972727.18875.14518854897359448582.gitbox@gitbox.apache.org> Date: Tue, 03 Apr 2018 07:15:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io commented on issue #1509: add unit test for remoting module URL: https://github.com/apache/incubator-dubbo/pull/1509#issuecomment-376053743 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr&el=h1) Report > Merging [#1509](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9deadadea3b1342345fed77c87a3d24ea026d7e6?src=pr&el=desc) will **increase** coverage by `0.49%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/graphs/tree.svg?src=pr&width=650&token=VnEIkiFQT0&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1509 +/- ## ========================================== + Coverage 31.59% 32.09% +0.49% ========================================== Files 682 682 Lines 33035 33035 Branches 6592 6592 ========================================== + Hits 10437 10602 +165 + Misses 20743 20539 -204 - Partials 1855 1894 +39 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `73.14% <0%> (-2.78%)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=) | `54.54% <0%> (-2.03%)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `55.22% <0%> (-1.5%)` | :arrow_down: | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.97% <0%> (-1.45%)` | :arrow_down: | | [...ing/transport/netty4/logging/MessageFormatter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9sb2dnaW5nL01lc3NhZ2VGb3JtYXR0ZXIuamF2YQ==) | `14.28% <0%> (+14.28%)` | :arrow_up: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNsaWVudEhhbmRsZXIuamF2YQ==) | `18.18% <0%> (+18.18%)` | :arrow_up: | | [...remoting/transport/netty4/logging/NettyHelper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9sb2dnaW5nL05ldHR5SGVscGVyLmphdmE=) | `20.75% <0%> (+20.75%)` | :arrow_up: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNoYW5uZWwuamF2YQ==) | `25% <0%> (+25%)` | :arrow_up: | | [...o/remoting/transport/netty4/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNvZGVjQWRhcHRlci5qYXZh) | `29.72% <0%> (+29.72%)` | :arrow_up: | | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlckhhbmRsZXIuamF2YQ==) | `31.7% <0%> (+31.7%)` | :arrow_up: | | ... and [4 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1509/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr&el=footer). Last update [9deadad...f96e764](https://codecov.io/gh/apache/incubator-dubbo/pull/1509?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services