dubbo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zonghaishang commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type
Date Mon, 09 Apr 2018 16:42:41 GMT
zonghaishang commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject
by type
URL: https://github.com/apache/incubator-dubbo/pull/1456#discussion_r180157548
 
 

 ##########
 File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/extension/SpringExtensionFactory.java
 ##########
 @@ -47,6 +52,24 @@ public static void removeApplicationContext(ApplicationContext context)
{
                 }
             }
         }
+
+        if (logger.isDebugEnabled()) {
+            logger.debug("No spring extension(bean) named:" + name + ", type:" + type.getName()
+ " found. Will try to get bean by type only.");
+        }
+
+        for (ApplicationContext context : contexts) {
+            try {
+                return context.getBean(type);
 
 Review comment:
   We should consider multiple matching conditions for the same interface type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message