dubbo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ralf0131 commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.
Date Sun, 08 Apr 2018 06:19:33 GMT
ralf0131 commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig
vars by Constants.
URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379524089
 
 
   I think this pull request contains two separated enhancement.
   
   1. SerivceAnnotationBeanPostProcessor bug 
   2. replace ServiceConfig vars by Constants
   
   If they are not related, please separate them into two pull request.
   For the SerivceAnnotationBeanPostProcessor bug fix, please make sure there is an issue
describing what the bug is and if you can provide a test case to reproduce it, that will be
better.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message