dubbo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] htynkn opened a new pull request #1558: [Dubbo-1513] add checkstyle with basic rule
Date Fri, 06 Apr 2018 06:41:25 GMT
htynkn opened a new pull request #1558: [Dubbo-1513] add checkstyle with basic rule
URL: https://github.com/apache/incubator-dubbo/pull/1558
 
 
   ## What is the purpose of the change
   
   Add checkstyle plugin.
   
   Apply some basic checkstyle rule like AvoidStarImport,OuterTypeFilename. Also add file
header check for Apache License.
   
   Close #1513 
   
   ## Brief changelog
   
   Apply checkstyle maven plugin in parent pom file. Only active in jdk 1.8 and above.
   `checkstyle-header.txt` is header file which every file should has it.
   
   There are some rule should apply according to https://github.com/apache/incubator-dubbo/blob/master/CONTRIBUTING.md#code-conventions
for example. line length must less than 120. But current files need fix. There are too many
work for this.
   
   We can have separate task for them later.
   
   ## Verifying this change
   
   CI Pass
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   - [x] Make sure there is a [GITHUB_issue](https://github.com/alibaba/dubbo/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
   - [x] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test`  to make sure integration-test pass.
   - [x] If this contribution is large, please file an [Apache Individual Contributor License
Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message