From dev-return-138-archive-asf-public=cust-asf.ponee.io@dubbo.apache.org Wed Mar 14 02:46:35 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A537718064F for ; Wed, 14 Mar 2018 02:46:34 +0100 (CET) Received: (qmail 56406 invoked by uid 500); 14 Mar 2018 01:46:33 -0000 Mailing-List: contact dev-help@dubbo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@dubbo.apache.org Delivered-To: mailing list dev@dubbo.apache.org Received: (qmail 56390 invoked by uid 99); 14 Mar 2018 01:46:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Mar 2018 01:46:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 68028C04DD for ; Wed, 14 Mar 2018 01:46:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.879 X-Spam-Level: ** X-Spam-Status: No, score=2.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id qy75oYcaHsWW for ; Wed, 14 Mar 2018 01:46:31 +0000 (UTC) Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com [209.85.218.51]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id F14F75F126 for ; Wed, 14 Mar 2018 01:46:30 +0000 (UTC) Received: by mail-oi0-f51.google.com with SMTP id b8so1399467oib.11 for ; Tue, 13 Mar 2018 18:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=njvaVXeamTeunWyXSiR36SLj7uTWdqYfxsh7sgu/A14=; b=YKpak25s5eoZ0uQ9gp8ZXb/QBxgDSFbRNlUqXbC2kB+3HQSvPFp3iTcgOy3BpFUYtl 2+QcfVYbUxwzcjStaxWHlQ3lYT8Q5PpO9ExicgGVH52cAgbnAoeCPzc5A1O7I6vIZhhd bkuQP2po2J24T4BadCnzUxDWaJLVS4Q5mrj7Bl8q8/nTiMFu1TEH7Bzj2jBk/niN2l+n yjOndX7ssltp2weVIxitG5eWOjZl2MfH9ODPK1NuwGng/cphQsxXbVXf0s+awW5c8Z/p ZLgIP5oekLojdCjfI8X5NrIVKUAoWoS1SWzWT0ni5BkATixnXKwp2t2lFLbmmZIhM8UK cseg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=njvaVXeamTeunWyXSiR36SLj7uTWdqYfxsh7sgu/A14=; b=Fyzjm8AU83eaSJm+yAMBbDes2tOnmuXfjKPOesI7wv7aI+lP1c60mlQG69kHS8doNe ExthvdVPcFQJPhnpZ/KsOihEKqALZH5juvrn5h5S/hRVqwSJBIupqCqwuZJdG9wR/PcM 5OjbXOp4PznGDBoBEdH4QsBdHlYG8nQ24zTVD0fgvtrXs/BwnhDeXBfdUGeYXivIQ0Xl cEZkAjJlR8xfKqQYg+/gbIsv8+6Z/aGi+2e0Kmy8BuQDrqzXoPtwBTd/eP9N75n7W6eB 2mMR29N0/TkLLwFXnFiV49JsoBV0YfF4YKZMAQqL8/skhl21klArxRJLamRH4baYR7mi xm7A== X-Gm-Message-State: AElRT7GXb0GY9nvOu6TFdYfnonHW2qIpw0EjJH3FW5JBQl9snnq6yvZI +4bwJtlPMOGO4CGo1RSaA6ZF/Q40 X-Google-Smtp-Source: AG47ELvfHF2OocsdrPYa2zuxDmv/38E/BfOnQeECn/h99NkldG4LfmnSOyH4IhTpMFWp4j1CMKpwLQ== X-Received: by 10.202.195.13 with SMTP id t13mr1850703oif.40.1520991983855; Tue, 13 Mar 2018 18:46:23 -0700 (PDT) Received: from [30.5.96.121] ([205.204.117.27]) by smtp.gmail.com with ESMTPSA id r7sm282179otr.44.2018.03.13.18.46.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 18:46:23 -0700 (PDT) From: jun liu Content-Type: multipart/alternative; boundary="Apple-Mail=_269FBBEE-61AB-4E7A-8085-67E1EB037D41" Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) Subject: Re: The new release version v2.5.10 has missed a feature, how can we avoid it? Date: Wed, 14 Mar 2018 09:46:20 +0800 References: <8DEDA0BB-7ADB-4862-B4E1-0E6C7465CD87@gmail.com> To: dev@dubbo.apache.org In-Reply-To: <8DEDA0BB-7ADB-4862-B4E1-0E6C7465CD87@gmail.com> Message-Id: X-Mailer: Apple Mail (2.3445.4.7) --Apple-Mail=_269FBBEE-61AB-4E7A-8085-67E1EB037D41 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 BTW, since you have mentioned the release of v2.5.10, i think there=E2=80=99= s no need for a separate release announcement on the mailing list.=20 I=E2=80=99ve create an announcement on github: = https://github.com/alibaba/dubbo/issues/1465 = > On 14 Mar 2018, at 9:36 AM, jun liu wrote: >=20 >> How can we avoid it? I think we can do like this : >> 1. When you create a pull request=EF=BC=8Cyou should choose a = branch as base branch (master or 2.5.x). >> 2. If it is a bug branch, should be created using 2.5.x branch = as a basic branch, sign a "bug" tag in the issue. >> Else if a new feature, should use master branch as a basic = branch,sign a "enhancement feature" tag . >=20 > For contributors, please make sure all changes on the right base = branch, that is, only use 2.5.x branch for bugfixes, otherwise use = master. >=20 > For committers, make sure select the right label and target branch for = every PR, make sure 2.5.x merge to master as soon as possible=E3=80=82 >=20 >> On 13 Mar 2018, at 4:43 PM, Wang Xin wrote: >>=20 >> Hi =EF=BC=8Call >>=20 >> Recently,the v2.5.10 is published. It is from 2.5.x branch. But = a PR (https://github.com/alibaba/dubbo/pull/1401) I created is missed. = Because my PR is merged to master branch,but not be merged to 2.5.x >>=20 >> How can we avoid it? I think we can do like this : >> 1. When you create a pull request=EF=BC=8Cyou should choose a = branch as base branch (master or 2.5.x). >> 2. If it is a bug branch, should be created using 2.5.x branch = as a basic branch, sign a "bug" tag in the issue. >> Else if a new feature, should use master branch as a basic = branch,sign a "enhancement feature" tag . >>=20 >> What do you think about? >>=20 >> Xin Wang >> lovepoem@hotmail.com >>=20 >>=20 >>=20 >=20 --Apple-Mail=_269FBBEE-61AB-4E7A-8085-67E1EB037D41--