dubbo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] gavincook opened a new pull request #1520: comments in URL class is incorrect
Date Wed, 28 Mar 2018 01:50:46 GMT
gavincook opened a new pull request #1520: comments in URL class is incorrect
URL: https://github.com/apache/incubator-dubbo/pull/1520
   ## What is the purpose of the change
   correct the comments in URL class
   ## Brief changelog
   the protocol description for file url is incorrect
   ## Verifying this change
   Follow this checklist to help us incorporate your contribution quickly and easily:
   - [x] Make sure there is a [GITHUB_issue](https://github.com/alibaba/dubbo/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a GITHUB issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config
not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message