dubbo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] laddcn opened a new pull request #1507: Mirror improvement for test cases in dubbo-rpc-api module
Date Sun, 25 Mar 2018 13:33:11 GMT
laddcn opened a new pull request #1507: Mirror improvement for test cases in dubbo-rpc-api
module
URL: https://github.com/apache/incubator-dubbo/pull/1507
 
 
   1. Use org.junit.Assert instead of junit.framework.Assert(@Deprecated since Junit 4)
   2. Use assertTrue and other assert methods through static import to make codes easier to
read
   
   ## What is the purpose of the change
   In dubbo-rpc-api module:
   1.  Since junit.framework.Assert are deprecated since Junit 4 and other test case classes
in this module have already use org.junit.Assert for instead, it is necessary to update related
codes in StatItemTest  and RpcUtilsTest.
   2.  Make codes more easy to read
   
   
   ## Brief changelog
   In dubbo-rpc-api module:
   1. Use org.junit.Assert instead of junit.framework.Assert(@Deprecated since Junit 4)
   2. Use assertTrue and other assert methods through static import to make codes easier to
read
   
   ## Verifying this change
   
   Test cases run with success
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message