dubbo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kimmking commented on a change in pull request #1475: update StringUtils isBlank and add isNotBlank method
Date Tue, 20 Mar 2018 07:15:44 GMT
kimmking commented on a change in pull request #1475: update StringUtils isBlank and add isNotBlank
method
URL: https://github.com/apache/incubator-dubbo/pull/1475#discussion_r175670972
 
 

 ##########
 File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/StringUtils.java
 ##########
 @@ -48,9 +48,18 @@ private StringUtils() {
     }
 
     public static boolean isBlank(String str) {
-        if (str == null || str.length() == 0)
-            return true;
-        return false;
+        if (isEmpty(str)) return true;
+
+        for (int i = 0; i < str.length(); i++) {
 
 Review comment:
   trim不就是去掉空字符吗?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message