druid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxime Beauchemin <maximebeauche...@gmail.com>
Subject Re: Druid repo migration plan
Date Fri, 22 Jun 2018 18:50:53 GMT
@julian gotcha, I thought this was a more official vote

The Superset GH move INFRA ticket shows how the move can be really
tricky/slow/disruptive. There was quite a period of instability for us and
a lot of slow back and forth with Apache infra. Hopefully the process has
been ironed out since then. Be prepared and go into it knowing that you may
not be able to merge PRs for days/weeks.
https://issues.apache.org/jira/browse/INFRA-14267

On the ticket you open with INFRA, make it really clear what your GH
integrations are and validate that they are all approved/supported by
Apache prior to the move. Some integrations (like codeclimate) require
rights on the GH org (Apache) and INFRA is categoric against that. If some
services aren't supported make sure to disable the integrations prior to
the move, find replacement services. Also make sure INFRA will adjust/tweak
the integration post move as you likely need admin rights to do so.

A caveat is around the "redirect chain" on GH. This is what allows hitting `
github.com/airbnb/superset` to redirect to `
github.com/apache/incubator-superset` to redirect to the right place. This
also allows `git remote`s to just work post move. This redirect chain is
fragile and can break in some cases. Since you need elevated rights on both
orgs to move the repo (say airbnb and apache) and that both parties aren't
ok with that, it's typical to use a middleman org like `apacheinfra`. They
grant you admin right to that org and you move the repo to there, and they
do the second part. If, post move, the middleman was to fork a repo with
the same name, or create one, it would break the redirect chain. Something
INFRA should be aware of at this point and cautious around it. Also note
that some GH integrations work through the redirect chain and some don't
and require re-pointing/configuring the service to the new location.

Thing you can do to prepare and mitigate risks:
* make merge hook checks optional, so that if coverage, travis, or code
quality checks do not prevent merging, since it's likely those check won't
trigger and as a non-admin you won't be able to force-merge
* consider unprotecting protected branches so that you can push to master
if controlling master is important in your workflow. This way you can
effectively merge PRs without clicking the button on GH.
* make sure core committers have their Gitbox access setup, I think it can
be a bit tricky and may involve your mentor / infra pulling some levers on
whimsy

I hope this helps!

Max


On Thu, Jun 21, 2018 at 6:27 PM Jonathan Wei <jonwei@apache.org> wrote:

> This is the JIRA issue for the Druid migration:
> https://issues.apache.org/jira/browse/INFRA-16674
>
> - Jon
>
>
> On Thu, Jun 21, 2018 at 6:10 PM, Jonathan Wei <jonwei@apache.org> wrote:
>
> > > I generally approve of this idea, as long as Apache INFRA is willing
> and
> > able to make it happen. I know it’s straightforward to move a git
> > repository from a GitHub project to any other place, but I’m not sure
> > whether it’s possible to move GitHub issues etc. from one project to the
> > next. When Superset made the move, did they just move the repo, or did
> they
> > move issues/stars/PRs as well? Were Apache INFRA OK with this?
> >
> > Transferring ownership of the repo would preserve the issues/stars/PRs:
> > https://help.github.com/articles/about-repository-transfers/
> >
> > The Superset migration (
> https://issues.apache.org/jira/browse/INFRA-14267)
> > referenced Airflow as a model; based on this comment on the Airflow
> > migration (https://issues.apache.org/jira/browse/INFRA-11776?
> > focusedCommentId=15261771&page=com.atlassian.jira.
> > plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15261771), ASF
> > INFRA is OK with that kind of migration.
> >
> > It looks like we agree on this plan, so I'll go ahead and file the
> > migration JIRA issue.
> >
> > Thanks,
> > Jon
> >
> > On Thu, Jun 21, 2018 at 4:50 PM, Julian Hyde <jhyde@apache.org> wrote:
> >
> >> Max,
> >>
> >> A good pattern for any Apache project is to achieve consensus without
> >> explicit votes. This is what this thread is doing. “+1” is just
> shorthand
> >> for “I approve”. So, I don’t think a “[VOTE]” prefix is necessary.
> >>
> >> Jon,
> >>
> >> I generally approve of this idea, as long as Apache INFRA is willing and
> >> able to make it happen. I know it’s straightforward to move a git
> >> repository from a GitHub project to any other place, but I’m not sure
> >> whether it’s possible to move GitHub issues etc. from one project to the
> >> next.
> >>
> >> When Superset made the move, did they just move the repo, or did they
> >> move issues/stars/PRs as well? Were Apache INFRA OK with this?
> >>
> >> Julian
> >>
> >>
> >> > On Jun 21, 2018, at 2:05 PM, Maxime Beauchemin <
> >> maximebeauchemin@gmail.com> wrote:
> >> >
> >> > +1
> >> >
> >> > Note that usually we would expect voting thread to have a `[VOTE]`
> >> prefix
> >> > in the the email subject.
> >> >
> >> > Max
> >> >
> >> > On Thu, Jun 21, 2018 at 12:26 AM David Lim <davidlim@apache.org>
> wrote:
> >> >
> >> >> +1
> >> >>
> >> >> On Thu, Jun 21, 2018 at 12:55 AM, Himanshu <g.himanshu@gmail.com>
> >> wrote:
> >> >>
> >> >>> +1 ... Major milestone, thanks
> >> >>>
> >> >>> On Wed, Jun 20, 2018, 9:13 PM Gian Merlino, <gian@apache.org>
> wrote:
> >> >>>
> >> >>>> +1; thanks Jon!
> >> >>>>
> >> >>>> On Wed, Jun 20, 2018 at 5:52 PM Jihoon Son <jihoonson@apache.org>
> >> >> wrote:
> >> >>>>
> >> >>>>> +1
> >> >>>>>
> >> >>>>> Sounds good to me.
> >> >>>>>
> >> >>>>> Jihoon
> >> >>>>>
> >> >>>>> On Wed, Jun 20, 2018 at 5:12 PM Nishant Bangarwa <
> >> >>>>> nbangarwa@hortonworks.com>
> >> >>>>> wrote:
> >> >>>>>
> >> >>>>>> +1
> >> >>>>>>
> >> >>>>>> --
> >> >>>>>> Nishant Bangarwa
> >> >>>>>>
> >> >>>>>> Hortonworks
> >> >>>>>>
> >> >>>>>> On 6/20/18, 3:57 PM, "Jonathan Wei" <jonwei@apache.org>
wrote:
> >> >>>>>>
> >> >>>>>>    Hi all,
> >> >>>>>>
> >> >>>>>>    The SGA for Druid has been sorted out, we can get
started on
> >> >>>>> migrating
> >> >>>>>> the
> >> >>>>>>    old Github repo to Apache.
> >> >>>>>>
> >> >>>>>>    Based on the discussion in our previous migration
thread (
> >> >>>>>>
> >> >>>>>>
> >> >>>>>
> >> >>>> https://groups.google.com/forum/#!msg/druid-development/
> >> >>> q1ip-L8xpBk/GPK1LhC7BQAJ
> >> >>>>>> ),
> >> >>>>>>    it seems we favor using our existing Github PR and
issues
> >> >>>> workflows.
> >> >>>>>>
> >> >>>>>>    I'll file a JIRA ticket requesting transfer of
> >> >>>>>>    https://github.com/druid-io/druid to a Gitbox-style
Apache
> >> >> repo,
> >> >>>>>> keeping
> >> >>>>>>    the existing history of PRs/issues/stars/etc. (e.g.,
Superset:
> >> >>>>>>    https://github.com/apache/incubator-superset)
> >> >>>>>>
> >> >>>>>>    Before I do that, I wanted to open this thread for
a vote to
> >> >>>> confirm
> >> >>>>>> that
> >> >>>>>>    we're all okay with this plan, so please chime in
with an
> >> >>> approval
> >> >>>> or
> >> >>>>>> any
> >> >>>>>>    concerns that you may have.
> >> >>>>>>
> >> >>>>>>    Thanks,
> >> >>>>>>    Jon
> >> >>>>>>
> >> >>>>>>
> >> >>>>>>
> >> >>>>>
> >> >>>>
> >> >>>
> >> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
> >> For additional commands, e-mail: dev-help@druid.apache.org
> >>
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message