druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [druid] jon-wei opened a new pull request #11501: Allow kill task to mark segments as unused
Date Tue, 27 Jul 2021 07:45:33 GMT

jon-wei opened a new pull request #11501:
URL: https://github.com/apache/druid/pull/11501


   This PR adds a new `markAsUnused` option for the Kill Task, which allows it to mark any
segments within the specified interval as unused before deleting the unused segments within
an interval.
   
   This is useful for allowing the mark unused -> delete sequence to happen with a single
API call for the caller, as well as allowing the unmark action to occur under a task interval
lock.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities
via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not
be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, ensuring the
threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Mime
View raw message