druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [druid] bananaaggle opened a new pull request #11377: Add Environment Variable DynamicConfigProvider
Date Tue, 22 Jun 2021 10:39:19 GMT

bananaaggle opened a new pull request #11377:
URL: https://github.com/apache/druid/pull/11377


   As [9351](https://github.com/apache/druid/issues/9351) described, DynamicConfigProvider
should replace PasswordProvider. PasswordProvider has an implementation named EnvironmentVariablePasswordProvider,
which allow users to read config from environment variable. This PR provides a same implementation
for DynamicConfigProvider. There is an example for its usage:
   ```
   "DynamicConfigProvider": {
     "type": "environment",
            {
               "userNameVariable": "MY_USER_NAME_VAR",
               "passwordVariable": "MY_PASSWORD_VAR"
            }
   }
   ```
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities
via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not
be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the
threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Mime
View raw message