druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [druid] jihoonson opened a new pull request #11091: Query error tests
Date Sat, 10 Apr 2021 06:12:22 GMT

jihoonson opened a new pull request #11091:
URL: https://github.com/apache/druid/pull/11091

   Fixes https://github.com/apache/druid/issues/10756.
   ### Description
   A follow-up of #10833. This PR adds more unit tests for `JsonParserIterator` and integration
tests for query errors changed in https://github.com/apache/druid/pull/10746. To easily test
query errors from historicals, `ServerManagerForQueryErrorTest` is refactored to mimic other
query failures.
   ##### Key changed/added classes in this PR
    * `ITQueryErrorTest`
    * `ServerManagerForQueryErrorTest`
   This PR has:
   - [x] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities
via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not
be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, ensuring the
threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
   - [x] added integration tests.
   - [ ] been tested in a test Druid cluster.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

View raw message