druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8535: fix caching bug with multi-column group-by
Date Fri, 13 Sep 2019 22:45:37 GMT
vogievetsky commented on a change in pull request #8535: fix caching bug with multi-column
group-by
URL: https://github.com/apache/incubator-druid/pull/8535#discussion_r324391202
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java
 ##########
 @@ -639,7 +639,7 @@ public ResultRow apply(Object input)
 
               // Must convert generic Jackson-deserialized type into the proper type.
               resultRow.set(
-                  dimensionStart + dimPos,
+                  dimensionStart + dimPos++,
 
 Review comment:
   `for` loop looks like the best solution

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Mime
View raw message