druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-druid] renevan10 commented on a change in pull request #8484: Web console: Druid status displayed in a table
Date Fri, 13 Sep 2019 20:02:27 GMT
renevan10 commented on a change in pull request #8484: Web console: Druid status displayed
in a table
URL: https://github.com/apache/incubator-druid/pull/8484#discussion_r324347657
 
 

 ##########
 File path: web-console/src/dialogs/status-dialog/status-dialog.spec.tsx
 ##########
 @@ -27,4 +27,19 @@ describe('status dialog', () => {
     render(statusDialog);
     expect(document.body.lastChild).toMatchSnapshot();
   });
+  it('filters data that contains input', () => {
+    const data = [
+      'org.apache.druid.common.gcp.GcpModule',
+      'org.apache.druid.common.aws.AWSModule',
+      'io.imply.druid.UtilityBeltModule',
+    ];
+    let filterFunction;
+    filterFunction = (filter: { id: string | number; value: string }, row: { [x: string]:
any }) =>
+      String(row[filter.id]).includes(filter.value);
 
 Review comment:
   I've made the changes so it tests the component's filtering directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Mime
View raw message