druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] QiuMM edited a comment on issue #6371: Fix the forbidden apis check do not work issue
Date Mon, 24 Sep 2018 15:21:39 GMT
QiuMM edited a comment on issue #6371: Fix the forbidden apis check do not work issue
URL: https://github.com/apache/incubator-druid/pull/6371#issuecomment-424010824
 
 
   @leventov If there are compiled classes, forbidden-apis checks will work. That's the only
reason. Taking the CI `strict compilation` as an example, the maven build command is `mvn
clean -Pstrict -pl '!benchmarks' compile test-compile -B --fail-at-end`, `test-compile` is
run after `compile`. So when maven run `test-compile` there are compiled classes for the forbidden-apis
check plugin to work. And it just checks the source code classes not include test code classes
because the test code classes have not been generated(before this pr, the `testCheck` Mojo
runs in the `validate` phase, if change to `test-compile` phase, test code classes would also
be checked). 
   
   A CI build example [here](https://travis-ci.org/apache/incubator-druid/jobs/431840904),
check the log then you'll figure it out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Mime
View raw message