druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] QiuMM edited a comment on issue #6355: It seems the forbidden apis check do not work
Date Sun, 23 Sep 2018 20:11:44 GMT
QiuMM edited a comment on issue #6355: It seems the forbidden apis check do not work
URL: https://github.com/apache/incubator-druid/issues/6355#issuecomment-423843505
 
 
   The `forbiddenapis` plugin works on compiled classes. Currently, the Mojo runs in the `validate`
lifecycle phase, there may be no classes for it to check forbidden apis if we have cleared
all classes. To make it work, we have to run a compile command first, then the maven command
may like this `mvn clean compile compile` which is not elegant. So modify the execution phase
to `compile` may better.
   I'll open a PR to do this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Mime
View raw message