druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] shivtools commented on a change in pull request #6335: Added backpressure metric
Date Sun, 23 Sep 2018 02:58:33 GMT
shivtools commented on a change in pull request #6335: Added backpressure metric
URL: https://github.com/apache/incubator-druid/pull/6335#discussion_r219687004
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java
 ##########
 @@ -231,6 +234,11 @@ private boolean enqueue(ChannelBuffer buffer, long chunkNum) throws
InterruptedE
           final long currentQueuedByteCount = queuedByteCount.addAndGet(holder.getLength());
           queue.put(holder);
 
+          if (usingBackpressure && currentQueuedByteCount >= maxQueuedBytes &&
channelReadable.get()) {
 
 Review comment:
   @gianm Thanks so much for the review. Your feedback was really useful and I've made the
changes that you requested. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Mime
View raw message