druid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)
Date Sat, 22 Sep 2018 01:45:42 GMT
jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657534
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/TimelineServerView.java
 ##########
 @@ -36,6 +38,9 @@
   @Nullable
   TimelineLookup<String, ServerSelector> getTimeline(DataSource dataSource);
 
+  @Nullable
 
 Review comment:
   Does this need to be nullable? None of the implementations return null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Mime
View raw message