From issues-return-65820-archive-asf-public=cust-asf.ponee.io@drill.apache.org Fri May 17 16:06:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AC3FC18060F for ; Fri, 17 May 2019 18:06:01 +0200 (CEST) Received: (qmail 63463 invoked by uid 500); 17 May 2019 16:06:01 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 63446 invoked by uid 99); 17 May 2019 16:06:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 May 2019 16:06:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E13CE2A03 for ; Fri, 17 May 2019 16:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 241CB256C1 for ; Fri, 17 May 2019 16:06:00 +0000 (UTC) Date: Fri, 17 May 2019 16:06:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-7204) Add proper validation when creating plugin MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842292#comment-16842292 ] ASF GitHub Bot commented on DRILL-7204: --------------------------------------- arina-ielchiieva commented on pull request #1788: DRILL-7204: Add proper validation when creating plugin URL: https://github.com/apache/drill/pull/1788#discussion_r285189347 ########## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ########## @@ -126,9 +128,9 @@ } function deleteFunction() { - if (confirm("Are you sure?")) { - $.get("/storage/${model.getName()}/delete", serverMessage); - } + showConfirmationDialog("Are you sure?", function() { Review comment: Maybe we should improve message, something like: `Are you sure you want to delete ....?` or `'cp' plugin will be deleted. Proceed?`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Add proper validation when creating plugin > ------------------------------------------ > > Key: DRILL-7204 > URL: https://issues.apache.org/jira/browse/DRILL-7204 > Project: Apache Drill > Issue Type: Bug > Affects Versions: 1.16.0 > Reporter: Arina Ielchiieva > Assignee: Anton Gozhiy > Priority: Major > Fix For: 1.17.0 > > Attachments: alert.JPG, new_plugin.png > > > 1. Currently there is no failure when user attempts to create plugin without name. Screenshot attached. I think we need proper plugin name validation when creating plugin. > 2. When disabling and deleting plugin, alerts are used. Its better to use more user friendly message window. Screenshot attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)