drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-7204) Add proper validation when creating plugin
Date Fri, 17 May 2019 16:06:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842292#comment-16842292
] 

ASF GitHub Bot commented on DRILL-7204:
---------------------------------------

arina-ielchiieva commented on pull request #1788: DRILL-7204: Add proper validation when creating
plugin
URL: https://github.com/apache/drill/pull/1788#discussion_r285189347
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/storage/update.ftl
 ##########
 @@ -126,9 +128,9 @@
     }
 
     function deleteFunction() {
-      if (confirm("Are you sure?")) {
-        $.get("/storage/${model.getName()}/delete", serverMessage);
-      }
+      showConfirmationDialog("Are you sure?", function() {
 
 Review comment:
   Maybe we should improve message, something like: `Are you sure you want to delete ....?`
or `'cp' plugin will be deleted. Proceed?`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add proper validation when creating plugin
> ------------------------------------------
>
>                 Key: DRILL-7204
>                 URL: https://issues.apache.org/jira/browse/DRILL-7204
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.16.0
>            Reporter: Arina Ielchiieva
>            Assignee: Anton Gozhiy
>            Priority: Major
>             Fix For: 1.17.0
>
>         Attachments: alert.JPG, new_plugin.png
>
>
> 1. Currently there is no failure when user attempts to create plugin without name. Screenshot
attached. I think we need proper plugin name validation when creating plugin.
> 2. When disabling and deleting plugin, alerts are used. Its better to use more user friendly
message window. Screenshot attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message